search

tiagocoutinho / modbus-proxy

Connect multiple clients to modbus devices
Other
79 stars 15 forks source link

Missing full license text #41

Open dwrobel opened 2 months ago

dwrobel commented 2 months ago

Would you please consider adding a full text of the license to the sources?

I'd like to package the modbus-proxy in Fedora Linux distribution, however one of the requirement is to have a full copy of the license text. Excerpt from the packaging guidelines [1]:

Packagers should point out to upstream that by not including a proper full license text, they are making it difficult or impossible for anyone to comply with their desired license terms.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

tiagocoutinho commented 2 months ago

It's very kind of you to make a fedora package.

I'm not sure what is needed... is it a full copy of GPL into each source code file?

They already have a reference to the LICENSE:

# Distributed under the GPLv3 license. See LICENSE for more info.

Isn't it enough?

dwrobel commented 2 months ago

Isn't it enough?

Unfortunately no, reference is not a full copy of the license text. Please have a look at the lines 647-648 of the license text [1] which states that you need to provide a copy of the license along with the program (note: the canonical url of the license text is the www.gnu.org site [2]).

You can grab more ideas from the hello-world program which also contains the whole copy of the license text in the COPYING [3] file.

[1] https://git.savannah.gnu.org/cgit/hello.git/tree/COPYING#n647 [2] https://www.gnu.org/licenses/gpl-3.0.txt [3] https://git.savannah.gnu.org/cgit/hello.git/tree/COPYING