search

tiagojsrios / betfair-client-csharp

MIT License
1 stars 1 forks source link

MarketCatalogue model uses the same fields as MarketFilter #2

Closed Huweey closed 3 years ago

Huweey commented 3 years ago

Hi,

First off, I like your client, it's much cleaner than anything else I've found, and also on newer tech.

I noticed the MarketCatalogue model has the wrong properties, it has the same properties as the MarketFilter.

MarketCatalogue: https://github.com/tiagojsrios/betfair-client-csharp/blob/main/src/BetfairClient/BetfairClient.Models/Betting/MarketCatalogue.cs

MarketFilter: https://github.com/tiagojsrios/betfair-client-csharp/blob/main/src/BetfairClient/BetfairClient.Models/Betting/MarketFilter.cs

I'm happy to contribute if you need anything.

Cheers, Huw

tiagojsrios commented 3 years ago

Hello @Huweey,

First of all, thanks for your report and offering yourself to contribute. I'm already working on the fix, and I'll publish a new version soon.

I'm quite surprised seeing people using the library. I'll make sure that I put some hours on improving the client, as I have some ideas. Happy to hear that you enjoy using the library.

tiagojsrios commented 3 years ago

You can now download the new version @Huweey. https://www.nuget.org/packages/BetfairClient/1.0.7

Do let me know if you find any other issue!