search

tiagomarin / Space-Travelers-Hub

The Space Traveler's Hub is an application where users can check out availble space rockets and book them or cancel the previously made booking. Also users can find a list of current missions along with their brief description and can join the selected mission or leave the mission the user joined earlier.
MIT License
7 stars 0 forks source link

https://github.com/tiagomarin/Space-Travelers-Hub/projects/1 #81

Open tiagomarin opened 2 years ago

tiagomarin commented 2 years ago

link to project

My partner changed timezone and I'm alone for this week. I've already contacted Studend Success but they haven't answered me yet, it all happened today!

Nemwel-Boniface commented 2 years ago

Hello @tiagomarin :wave: ,

I'm Nemwel your reviewer for this PR :man_beard:

There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️

♻️ Required Changes ♻️

Check the comments under the review.

[Optional] suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! :partying_face: 👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

tiagomarin commented 2 years ago

Hi @Nemwel-Boniface, you wrote suggest, but it's you blocked the pull request, I got confused. But I'll delete anyways.

Thanks!

thecodechaser commented 2 years ago

STATUS: APPROVED 🟢

Hi @tiagomarin👋,

Your project is complete! There is nothing else to say other than... it's time to close it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.