tiagosiebler / bybit-api

Node.js SDK for the Bybit APIs and WebSockets, with TypeScript & browser support.
https://www.npmjs.com/package/bybit-api
MIT License
244 stars 80 forks source link

wrong types #237

Closed tony-riotracers closed 1 year ago

tony-riotracers commented 1 year ago

several types are wrong; for example, price and stopLoss are supposed to be strings, not numbers.

https://github.com/tiagosiebler/bybit-api/blob/f59438d1adf3090408f852f4cbc4f1811bcff139/src/types/request/linear.ts#L55

https://bybit-exchange.github.io/docs/derivatives/unified/place-order

tiagosiebler commented 1 year ago

Discussed over here: https://github.com/tiagosiebler/bybit-api/pull/238#issuecomment-1467921270

These types are for the v2 linear (USDT Perp) APIs, while the link is for the unified margin APIs (which are available via the unified margin client).