search

tiagosiebler / ftx-api

Node.js connector for the FTX.com & FTX.us APIs and WebSockets, with TypeScript & browser support.
https://www.npmjs.com/package/ftx-api
MIT License
123 stars 47 forks source link

Fixed 'getPositions' with 'showAveragePrice=false' #48

Closed DavDag closed 2 years ago

DavDag commented 2 years ago

issue https://github.com/tiagosiebler/ftx-api/issues/47

DavDag commented 2 years ago

Hi, i've tested the changes and now should works with 'false', 'true' and undefined.

image

tiagosiebler commented 2 years ago

Hi, i've tested the changes and now should works with 'false', 'true' and undefined.

image

Good catch! Can you also bump the package json version? It'll speed up release.

DavDag commented 2 years ago

Hi, i've tested the changes and now should works with 'false', 'true' and undefined. image

Good catch! Can you also bump the package json version? It'll speed up release.

Of course. Updating "version" field should be enough ?

tiagosiebler commented 2 years ago

Hi, i've tested the changes and now should works with 'false', 'true' and undefined. image

Good catch! Can you also bump the package json version? It'll speed up release.

Of course. Updating "version" field should be enough ?

Yes, just change this number: https://github.com/tiagosiebler/ftx-api/blob/master/package.json#L3

To the next one up: 1.0.19

DavDag commented 2 years ago

I've done it already https://github.com/tiagosiebler/ftx-api/pull/48/commits/1947d8a7891f17c4f84941bcfc54d0cba471d64b and thank you for the feedbacks !