Closed d3c0d3dpt closed 2 years ago
I'm glad to help!
Compiling the package as it was yielded no errors, so maybe it's some kind of TS configuration?
That's my first thought too. Could you share the tsconfig you were using? Perhaps the one in the project needs an adjustment as I don't want this kind of mistake to slip through again
Sure, here it goes:
{
"compilerOptions": {
"target": "es2019",
"module": "commonjs",
"moduleResolution": "node",
"baseUrl": ".",
"outDir": "build",
"declaration": true,
"esModuleInterop": true,
"noImplicitAny": true,
"sourceMap": false,
"types": [
"node"
]
},
"include": [
"index.ts",
"bin/**/*",
"src/**/*",
"types/**/*"
]
}
Still not sure why it errored for, but seems like it's the baseUrl option that's the culprit. While set, you can use non-relative paths - which in this case is not desirable. I've removed it and now it throws during build time if the path isn't relative.
Closes #
Summary
Fix a path issue on
typeGuards.ts
.Using TypeScript to compile a project using ftx-api@1.1.0 will generate the following error:
This PR addresses that issue, allowing a successful compilation.
Local tests were performed by compiling the package and installing it (using
npm i ../ftx-api/ftx-api-1.1.1.tgz
) and checking if the the compilation was successful.Checks