tiagovla / tokyodark.nvim

A clean dark theme written in lua for neovim.
453 stars 19 forks source link

Lualine color for lualine_z section in Normal mode #32

Closed shreyas-a-s closed 3 months ago

shreyas-a-s commented 4 months ago

First of all, thank you Tiago for creating this wonderful theme. I was continuousily hopping between tokyonight by folke, darkplus by LunarVim and kanagawa by rebelot and every one of them had one or two issues for my liking. But yours, man, so perfect.

When it comes to our 'issue', as we can see, in all other modes lualine_z section (righmost section) of Lualine does have matching color as the lualine_a section but not in NORMAL mode.

Screencast from 2024-03-08 01-11-36.webm

Looking at the code, I think this last line in lua/lualine/themes/tokyodark.lua is the problem:

    normal = {
        a = { fg = colors.bg, bg = colors.green, gui = "bold" },
        b = { fg = colors.fg, bg = colors.bg },
        c = { fg = colors.fg, bg = colors.bg },
        x = { fg = colors.fg, bg = colors.bg },
        y = { fg = colors.fg, bg = colors.bg },
        z = { fg = colors.fg, bg = colors.bg }, -- problematic line
    },

Changing the line to z = { fg = colors.bg, bg = colors.green, gui = "bold" }, or even deleting the line altogether fixes the issue.

I think for maintaining a uniformity with other modes, changing the line to match lualine_a section line would be the ideal choice.

Thank you for reading though this message.

tiagovla commented 3 months ago

Could you submit a PR?

shreyas-a-s commented 3 months ago

Certainly.

shreyas-a-s commented 3 months ago

PR submitted.