highlight error messages

maxdevjs commented 2 years ago

Hello,

first of all, be aware: this theme is amazing :smiley:

NVIM v0.5.1 Build type: Release LuaJIT 2.1.0-beta3 theme installed via paq

Case 1: with yamatsum/nvim-cursorline

I had yamatsum/nvim-cursorline installed.

If I set tokyodark.nvim in the configuration files, I receive the following error (but, apparently, the theme is then loaded correctly):

Error detected while processing CursorMoved Autocommands for "*":
E5108: Error executing lua .../pack/paqs/start/nvim-cursorline/lua/nvim-cursorline.lua:66: Vim(highlight):E417: missing argum
ent: guibg=

If I set the theme in nvim (i.e.: :colo tokyodark), I do not receive any error message.

Case 2: without yamatsum/nvim-cursorline

If I get rid of yamatsum/nvim-cursorline and I set tokyodark.nvim in the configuration files:

Error executing vim.schedule lua callback: ...k/paqs/start/tokyodark.nvim/lua/tokyodark/highlights.lua:253: handle 0x018c1bc0
 is already closing

again, if I set the theme in nvim (i.e.: :colo tokyodark), I do not receive any error message.

I get the error messages independently of setting or not a configuration for the theme.

themes.lua

I tried to mimic your themes.lua:

Error executing vim.schedule lua callback: ...k/paqs/start/tokyodark.nvim/lua/tokyodark/highlights.lua:253: handle 0x01af4cd0
 is already closing

Any hint?

tiagovla commented 2 years ago

@maxdevjs neovim 0.5 nightly used to support the async function I was using, 0.6 still does. I removed async loading for now. Could you please update it and check if it's working?

maxdevjs commented 2 years ago

@tiagovla I am sorry, I did not know about the plugin depending on the nightly (in fact, I previously had the nightly installed, but then switched to stable).

I did a quick check and now it works without any error.

Anyway, if I may suggest: perhaps a simple note can be added in the README about the nightly dependency, allowing you to re-add the async loading :)

tiagovla commented 2 years ago

Support was meant for 0.5 and higher, and as 0.5 nightly worked, I assumed 0.5 stable would too. I will check how other plugins are doing the async call. I noticed that some even removed it claiming it was not improving loading time. Glad it worked.

maxdevjs commented 2 years ago

Thank you for the quick and effective support :)

tiagovla / tokyodark.nvim