search

tiaguinho / gosoap

🦉SOAP package for Go
MIT License
508 stars 176 forks source link

Return errors if definitions/services not found in wsdl definitions #15

Closed eloyekunle closed 5 years ago

eloyekunle commented 5 years ago

This PR adds 2 error checks to the SOAP Client.Call function.

  1. Checks if Client.Definitions exists
  2. Checks if Client.Definitions.Service exists.

It aims to solve 2 error-able cases:

  1. When the WSDL definitions are empty, return an error e.g. At #14
  2. When the Client.Call function is called with an empty Client. e.g. At #13
codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6e32cde). Click here to learn what that means. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   71.07%           
=========================================
  Files             ?        3           
  Lines             ?      204           
  Branches          ?        0           
=========================================
  Hits              ?      145           
  Misses            ?       53           
  Partials          ?        6
Impacted Files Coverage Δ
soap.go 83.33% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e32cde...c4cd93d. Read the comment docs.