Closed twz915 closed 4 years ago
Merging #59 into master will decrease coverage by
2.87%
. The diff coverage is15.38%
.
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 71.37% 68.49% -2.88%
==========================================
Files 5 5
Lines 262 273 +11
==========================================
Hits 187 187
- Misses 63 74 +11
Partials 12 12
Impacted Files | Coverage Δ | |
---|---|---|
encode.go | 59.39% <0.00%> (-5.36%) |
:arrow_down: |
request.go | 75.00% <100.00%> (ø) |
|
soap.go | 72.63% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a53d7a4...465a3c6. Read the comment docs.
Thank you for the PR @twz915. Can you take a look at the tests? The changes you have done has decreased by more than 2% of the coverage we have.
@codecov-io test again?
I tested the change and the coverage increase a ~2% and PR works like a charm. Unfortunelly Codecov don't update in github the coverage, @tiaguinho should see the Codecov link instead.
I like this change, I will be using it in my project until it is merged. Thanks @twz915
Works perfectly.
Thanks @twz915
Merging #59 into master will increase coverage by
2.46%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 71.16% 73.62% +2.46%
==========================================
Files 5 5
Lines 267 273 +6
==========================================
+ Hits 190 201 +11
+ Misses 64 60 -4
+ Partials 13 12 -1
Impacted Files | Coverage Δ | |
---|---|---|
encode.go | 69.92% <100.00%> (+5.17%) |
:arrow_up: |
request.go | 75.00% <100.00%> (ø) |
|
soap.go | 72.63% <100.00%> (+1.20%) |
:arrow_up: |
wsdl.go | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 84f9e16...1fa3d03. Read the comment docs.
see https://github.com/tiaguinho/gosoap/issues/53