tian-zhihui / cordysfilecon

Automatically exported from code.google.com/p/cordysfilecon
Apache License 2.0
0 stars 0 forks source link

Ugly code in ExcelRead.java #32

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Problems with ExcelRead.java:
* It is not in line with the rest of the code.
* Also there are quite a few compiler warnings. Raw types and unused variables.
* There is an an empty catch block. This means exceptions get ignored, which 
can't be correct. The bare minimum should AT LEAST be write the exception to 
the log file. If the processing can continue, then you log it as a warning. But 
usually you throw the exception back up and let a higher level decide what to 
do with the exception

See: 
http://code.google.com/p/cordysfilecon/source/browse/trunk/src/java/com/cordys/c
oe/ac/fileconnector/utils/ExcelRead.java

Original issue reported on code.google.com by ma...@vandeveen.com on 15 Aug 2011 at 6:18

GoogleCodeExporter commented 8 years ago
Fixed in r91

Original comment by srkrish...@cordys.com on 4 Jan 2012 at 12:25