search

tian-zhihui / cordysfilecon

Automatically exported from code.google.com/p/cordysfilecon
Apache License 2.0
0 stars 0 forks source link

Code review request #41

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Purpose of code changes on this branch:
Ported the sources to bop 4.1 cu7

When reviewing my code changes, please focus on:
1. coe\fileconnector\ac\fileconnectorconfig.caf (File Connector Configuration 
UI),
2. Java Code (Changed all the Exceptions to throw with IStringResource instead 
of plain text)
3. Message Bundles (Added all the exception messages to message bundles)

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by gkaviyar...@cordys.com on 28 May 2012 at 6:42

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi All,

Its been a long time that I have requested for this code review. Can you please 
provide the feedback on this? We will take this feedback as input for other 
Community connectors migration. Please guide be accordingly if you can not do 
the review or so.

Thanks & Regards,
Kaviyarasu G.

Original comment by gkaviyar...@cordys.com on 13 Jun 2012 at 4:20

GoogleCodeExporter commented 8 years ago 
I've taken a look and the project structure of the CWS project is not correct.

Please take a look at the attached files to see how a BOP 4 project should look 
from a structure perspective.

Original comment by pgus...@cordys.com on 13 Jun 2012 at 5:38

Attachments:

GoogleCodeExporter commented 8 years ago 
Please consider providing a CAP package in parallel to the ISV package.

Original comment by te...@cordys.com on 13 Jun 2012 at 7:26

GoogleCodeExporter commented 8 years ago 
Hi Phillip,

Thanks for your input. I have modified the project structure. Please review it 
now. In case if any other changes require, please specify it.
Please review the java code and the UI which I specified above.

Note: The UI location has been changed to 
com/cordys/coe/fileconnector/ac/fileconnectorconfig.caf

Thanks and Regards,
Kaviyarasu G.

Original comment by gkaviyar...@cordys.com on 14 Jun 2012 at 8:49

GoogleCodeExporter commented 8 years ago 
Can you attach the full project? Or mail me the full project? So the eclipse 
project (which has the CWS structure in the src/cws)?

You could also create a branch here and commit the changes to the branch. Once 
the branch is fully ok we can do the copy to trunk.

Original comment by pgus...@cordys.com on 14 Jun 2012 at 9:29

GoogleCodeExporter commented 8 years ago 
Hi
I missed the Attachment in the previous comment.

Regards,
Kaviyarasu G

Original comment by gkaviyar...@cordys.com on 14 Jun 2012 at 9:32

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi All,

Please provide the feedback or the changes as soon as possible. 
In case any changes are required, I will complete them and commit. Otherwise I 
am planning to commit  the code to trunk on EOB(15/06/2012) IST.
Since there are no application logic change(The changes are specified in the 
issue description) I hope there won't be any issue committing the code.

Regards,
Kaviyarasu G.

Original comment by gkaviyar...@cordys.com on 15 Jun 2012 at 9:00

GoogleCodeExporter commented 8 years ago 
Code-wise there are no remarks.. I just think the whole project structure is 
not correct. But I am not sure that I have time today to change it to what it 
should be...

Original comment by pgus...@cordys.com on 15 Jun 2012 at 9:12

GoogleCodeExporter commented 8 years ago 
Hi,

Can you please correct or advise me on that to correct the structure before the 
end of this week?

Regards,
Kaviyarasu G.

Original comment by gkaviyar...@cordys.com on 20 Jun 2012 at 8:48

GoogleCodeExporter commented 8 years ago 
Look at the document I attached. Also look at the other ZIP I attached. In that 
document is described exactly what the structure should be.

What it comes down to:

/svn/trunk - Contains the root of the Eclipse project
/svn/trunk/src/cws - Contains the root URL for CWS.

I've attached a CU6 version of the project as I don't have CU7 installed. But I 
think you can use it as a basis

Original comment by pgus...@cordys.com on 20 Jun 2012 at 12:02

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi

I have made the changes and committed in the branch section,
https://cordysfilecon.googlecode.com/svn/branches/BOP4.1cu7-migration

Please see the structure again and let me know your feedback.

Regards,
Kaviyarasu G.

Original comment by gkaviyar...@cordys.com on 21 Jun 2012 at 6:46

GoogleCodeExporter commented 8 years ago 
Did you even look at the project I attached?

Original comment by pgus...@cordys.com on 21 Jun 2012 at 6:51