Use `${VARIABLE:?Variable not found}` instead of ${VARIABLE} where needed

tiangolo / dockerswarm.rocks

Docker Swarm mode rocks! Ideas, tools and recipes. Get a production-ready, distributed, HTTPS served, cluster in minutes, not weeks.

https://dockerswarm.rocks/

1.1k stars 125 forks source link

Use `${VARIABLE:?Variable not found}` instead of ${VARIABLE} where needed #14

Closed dmrty closed 4 years ago

dmrty commented 5 years ago

FYI, I've started to use ${VARIABLE:?Variable not found} when there is no obvious default so that the deploy crash if the variable is not set: See docker reference on variable substitution for more info. Maybe that would make sense to change the ${VARIABLE} or ${VARIABLE:-} by ${VARIABLE:?} for a more solid deploy process?

Originally posted by @dmrty in https://github.com/tiangolo/dockerswarm.rocks/issues/12#issuecomment-491737577

tiangolo commented 5 years ago

Good idea! Let's continue the discussion here.

tiangolo commented 4 years ago

Now that your PR is merged, I think we can close this issue, right @dmrty ?

dmrty commented 4 years ago

Indeed