search

tiangolo / fastapi

FastAPI framework, high performance, easy to learn, fast to code, ready for production
https://fastapi.tiangolo.com/
MIT License
73.78k stars 6.22k forks source link

add some tests for jsonable_encoder as first contribution #11414

Closed elefher closed 3 months ago

elefher commented 3 months ago

Hi 👋

I'm excited to submit my first pull request for FastAPI. After admiring the project for its excellence, I've taken the initiative to delve into its source code and contribute. For my debut PR, I've chosen to add a couple of tests for the jsonable_encoder function.

Thank you for the opportunity to contribute to such an outstanding project!

tiangolo commented 3 months ago

Thanks for the interest @elefher! :nerd_face:

I wouldn't consider these tests necessary as what they test is already covered by other tests. So I'll pass on this one.

If you would like to help, there are several ways to do it, for example, answering questions from others helps a lot! :coffee:

https://fastapi.tiangolo.com/help-fastapi/