🔥 Remove isort configuration, since we use Ruff now

tiangolo / full-stack-fastapi-template

Full stack, modern web application template. Using FastAPI, React, SQLModel, PostgreSQL, Docker, GitHub Actions, automatic HTTPS and more.

MIT License

24.53k stars 4.14k forks source link

🔥 Remove isort configuration, since we use Ruff now #1144

Closed patrick91 closed 3 months ago

patrick91 commented 3 months ago

This PR removes the isort configuration from pyproject.toml

The configuration options we had set aren't supported by ruff just yet, but I think the default config is pretty much what we want (after all running ruff now didn't change anything).

I'm also removing the calls to isort, since we want to use ruff for this.

I've also update the format.sh script to use ruff, do we want to keep it?

estebanx64 commented 3 months ago

@patrick91 format.sh can be removed, if you see lint.sh is doing what you wrote in format.sh and was called just by format-import.sh which was removed in your PR too

tiangolo commented 3 months ago

Great, thanks @patrick91! :rocket:

I restored format.sh with the updated commands, it's quite similar with lint.sh, but it's actually different, lint.sh only shows errors, doesn't modify the code, format.sh modifies the code.