tiangolo / full-stack-fastapi-template

Full stack, modern web application template. Using FastAPI, React, SQLModel, PostgreSQL, Docker, GitHub Actions, automatic HTTPS and more.
MIT License
24.53k stars 4.14k forks source link

🔧 Change `.nvmrc` format #1148

Closed patrick91 closed 3 months ago

patrick91 commented 3 months ago

I've noticed that 18.x.x is not supported by nvmrc:

❯ nvm install
Found '/Users/patrick/github/patrick91/full-stack-fastapi-template/frontend/.nvmrc' with version <18.x.x>
Version '18.x.x' not found - try `nvm ls-remote` to browse available versions.

it also doesn't work with mise (a similar tool that I use), but using 18 works fine for both tools 😊

18 and 18.x.x both work for fnm 😊

alejsdev commented 3 months ago

Thank you! :rocket: @patrick91