♻️ Refactored code to use encryption algorithm name from settings for consistency

tiangolo / full-stack-fastapi-template

Full stack, modern web application template. Using FastAPI, React, SQLModel, PostgreSQL, Docker, GitHub Actions, automatic HTTPS and more.

MIT License

24.53k stars 4.14k forks source link

♻️ Refactored code to use encryption algorithm name from settings for consistency #1160

Open sameeramin opened 3 months ago

sameeramin commented 2 months ago

Thank you @menkotoglou, please let me know what else I need to do in order to get this PR merged.

menkotoglou commented 2 months ago

@sameeramin unfortunately I cannot do anything about it, since I'm not a repo maintainer.

sameeramin commented 1 month ago

Thank you for the interest!

I don't think the algorithm should be configurable in the settings, it shouldn't really be variable. Let's better keep it in security.py.

But I agree that the backend utils should use the same variable from security.py. 🤓 Could you please update that?

Sure, I'll update that!