search

tiangolo / full-stack-fastapi-template

Full stack, modern web application template. Using FastAPI, React, SQLModel, PostgreSQL, Docker, GitHub Actions, automatic HTTPS and more.
MIT License
24.9k stars 4.22k forks source link

Update user without password causes error #358

Open turukawa opened 3 years ago

turukawa commented 3 years ago

When updating a user's details without updating the password, the backend fails. The issue is very simple:

https://github.com/tiangolo/full-stack-fastapi-postgresql/blob/490c554e23343eec0736b06e59b2108fdd057fdc/%7B%7Bcookiecutter.project_slug%7D%7D/backend/app/app/crud/crud_user.py#L34

No password is provided during update, so correct:

if update_data.get("password"):

NMisko commented 3 years ago

See this pull request https://github.com/tiangolo/full-stack-fastapi-postgresql/pull/168