search

tiangolo / full-stack

Full stack, modern web application generator. Using Flask, PostgreSQL DB, Docker, Swagger, automatic HTTPS and more.
MIT License
523 stars 81 forks source link

update deprecated traefik auth label in swarm deploy documentation #22

Closed AYEG closed 5 years ago

AYEG commented 5 years ago

After receiving Traefik service log warnings I've updated traefik.frontend.auth.basic in the deploy documentation to traefik.frontend.auth.basic.users

tiangolo commented 5 years ago

Thank you @AYEG !

I just noticed the same, one or two days ago while creating https://dockerswarm.rocks...

I wanted to make the tutorial just reference DockerSwarm.rocks. That way I can reference it from all the other project generators, like https://github.com/tiangolo/full-stack-fastapi-couchbase.

And then all the new updates are shared by all of them. For example, you might want to check the new Traefik HTTPS tutorial, that includes setting it up in a distributed manner, with a distributed Consul.

There's also a new section to add monitoring to the cluster with Swarmprom.

I just updated the docs here.

I'm sorry I won't be able to merge it, just for the timing. But thanks for the effort! I like how you're getting more and more active here, thanks for that! :tada: :taco:

AYEG commented 5 years ago

that is a very clever thing to do! I can see sharing those updates would makes sense for you