search

tiangolo / nginx-rtmp-docker

Docker image with Nginx using the nginx-rtmp-module module for live multimedia (video) streaming.
MIT License
1.05k stars 365 forks source link

Use multi-stage to save 700MB+ in image size #31

Closed ericb-summit closed 1 year ago

ericb-summit commented 2 years ago

Without this PR the image is 851MB. With it, it's 68MB.

I'd prefer a cleaner way to pull the artifacts from the builder stage other than listing them one by one as it's not very future-proof, but unless nginx upstream radically changes their make install behaviour, it should be safe.

tiangolo commented 1 year ago

This is super cool! Nevertheless, I wouldn't take it without tests to make sure it all keeps working, and I haven't added tests here, so I would rather keep it as is, even though this idea is great indeed. :pensive:

I'm currently not using this image myself, so I also don't have time or any other motivation to figure out a way to add some type of tests. But if at some point I end up adding tests, I'll consider this again.

But thanks for the effort! :coffee:

ericb-summit commented 1 year ago

Hey totally unerstand, and thanks for the reply.

github-actions[bot] commented 1 year ago

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.