tiann / KernelSU

A Kernel based root solution for Android
https://kernelsu.org
GNU General Public License v3.0
9.75k stars 1.59k forks source link

modules.img file size #1572

Closed xxjoe2 closed 5 months ago

xxjoe2 commented 5 months ago

hi

ok, i believe you have reasons to use a sparse file to hold the modules. however, i just wonder why you decided to make a 1T (and incerased from 256T) sparse file to hold them. do we really need to init a 1T sparse file in the first place?

this sparse file is way too large and causes a few problems, eg:

and since a new img will be created every time there are changes to the existing modules, so why do we increase the size of the sparse file at this time when needed? i would suggest to create a much smaller file first, say 500mb, and then increase the file size when needed after a module is installed. a 500mb image is more than enough to hold many modules

what do you think?

tiann commented 5 months ago

The previous versions used to increase in size during installation, but many modules would self-extract and download content from the internet, making it difficult to determine how much to increase. This resulted in many module installation failures.

In addition, the expansion process takes a lot of time, which leads to a slow module installation process; frequent expansion also increases the likelihood of image file damage.

If you want to backup, you can go to the settings and select "Minimize module image" now.

xxjoe2 commented 5 months ago

ok, i see. thank you

but where is the Minimize module image setting? i found in your strings.xml but couldnt find it in the app

tiann commented 5 months ago

Settings - Minimize Image file

xxjoe2 commented 5 months ago

no such option, v0.92 Screenshot_20240401_153050_KernelSU

or there should be something else below? i find it unable to scroll in landscape mode

i mean the page is not scrollable in landscape mode, so perhaps there are some other options below (non landscape mode) but i couldnt see them due to not scrollable?

xxjoe2 commented 5 months ago

alright, i changed the font size and now the options at the boottom are now visible. that is, this is a bug for not scrollable (the first page too)

Screenshot_20240401_161636_KernelSU

anyway, now i can see all the options but still no minimize image size option

mt190502 commented 5 months ago

Settings - Minimize Image file

I encountered a similar problem today. But I couldn't find this setting.