search

tianocore / containers

Repository to maintain and manage edk2 containers
Other
22 stars 26 forks source link

Enable GTK on Fedora QEMU #63

Closed cfernald closed 1 year ago

cfernald commented 1 year ago

Description

Enabled GTK in the built QEMU to enable local developers to use graphics.

Containers Affected

Fedora-35-test Fedora-35-dev Fedora-37-test Fedora-37-dev

osteffenrh commented 1 year ago

Hi @cfernald!

Just thinking about the image size. Do you know the impact of this?

Also curious, why is graphics (really) needed? Is serial terminal not sufficient?

cfernald commented 1 year ago

Hi @cfernald!

Just thinking about the image size. Do you know the impact of this?

Also curious, why is graphics (really) needed? Is serial terminal not sufficient?

Hey @osteffenrh !

I'm seeing about 110Mb increase locally. I also pushed a change to print the docker images during the build to make checking in the official build easier.

Right now this is just for dev scenarios where being able to use QEMU to validate both UEFI graphics and functionality in an OS is a common scenario, at least for us. We could move this into just the dev image if we want to re-compile QEMU for dev. Thoughts?

osteffenrh commented 1 year ago

Not sure if it is worth the maintenance effort to recompile qemu for the dev image/ 110MB is not so much, IMO.