search

tianocore / containers

Repository to maintain and manage edk2 containers
Other
20 stars 25 forks source link

Fedora 39 fixups #87

Closed osteffenrh closed 9 months ago

osteffenrh commented 9 months ago

Some fixups for the recently added Fedora 39 image:

Closes #84

Javagedes commented 9 months ago

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

makubacki commented 9 months ago

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage. There are some references used for the QEMU build that seem they could be dropped now though like QEMU_URL and QEMU_BRANCH.

osteffenrh commented 9 months ago

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage.

Exactly. Those packages were only needed for building Qemu.

Javagedes commented 9 months ago

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage.

Exactly. Those packages were only needed for building Qemu.

Thanks for the clarification @makubacki , @osteffenrh :)