tianocore / edk2-basetools

EDK II BaseTools Python tools as a PIP module
Other
25 stars 35 forks source link

Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change #89

Closed ghost closed 1 year ago

ghost commented 1 year ago

In order to support building BaseTools using non-default compilers, a change is being made in the edk2 BaseTools directory to remove the 'BUILD_' prefix to CC, CXX, CFLAGS etc. so developers can for example run 'make CC=clang CXX=clang++' to build using clang.

Update DscBuildData.py to generate Makefiles with CFLAGS instead of BUILD_CFLAGS.

Issue: #90

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (a4693eb) 4.28% compared to head (9f71ed1) 4.28%.

:exclamation: Current head 9f71ed1 differs from pull request most recent head 190c734. Consider uploading reports for the commit 190c734 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #89 +/- ## ========================================= - Coverage 4.28% 4.28% -0.01% ========================================= Files 181 181 Lines 81533 81537 +4 ========================================= Hits 3490 3490 - Misses 78043 78047 +4 ``` | Flag | Coverage Δ | | |---|---|---| | Linux | `4.28% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/tianocore/edk2-basetools/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore) | Coverage Δ | | |---|---|---| | [edk2basetools/Workspace/DscBuildData.py](https://codecov.io/gh/tianocore/edk2-basetools/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore#diff-ZWRrMmJhc2V0b29scy9Xb3Jrc3BhY2UvRHNjQnVpbGREYXRhLnB5) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.