tianocore / edk2-basetools

EDK II BaseTools Python tools as a PIP module
Other
25 stars 35 forks source link

DscBuildData.py: set CC_FLAGS2 when running on Windows #94

Closed ghost closed 1 year ago

ghost commented 1 year ago

CC_FLAGS2 also needs to be set when running on Windows, otherwise the wrong line is added and nmake fails when building using Visual Studio.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (34deebe) 4.28% compared to head (79c2c69) 4.28%.

:exclamation: Current head 79c2c69 differs from pull request most recent head 02126c5. Consider uploading reports for the commit 02126c5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #94 +/- ## ========================================= - Coverage 4.28% 4.28% -0.01% ========================================= Files 181 181 Lines 81537 81538 +1 ========================================= Hits 3490 3490 - Misses 78047 78048 +1 ``` | Flag | Coverage Δ | | |---|---|---| | Linux | `4.28% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/tianocore/edk2-basetools/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore) | Coverage Δ | | |---|---|---| | [edk2basetools/Workspace/DscBuildData.py](https://codecov.io/gh/tianocore/edk2-basetools/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore#diff-ZWRrMmJhc2V0b29scy9Xb3Jrc3BhY2UvRHNjQnVpbGREYXRhLnB5) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.