search

tianocore / edk2-pytool-extensions

Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment
Other
60 stars 40 forks source link

Add reference argument to submodule update --init invocations #842

Closed joschock closed 2 months ago

joschock commented 3 months ago

When resolving a repo with submodules via the repo_resolver::checkout() method, the reference argument (if appropriate) was not used for submodule updates as part of resolution. This PR adds support for the reference argument to allow references to be used throughout the resolution process.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (bf643b0) to head (6f75785). Report is 74 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tianocore/edk2-pytool-extensions/pull/842/graphs/tree.svg?width=650&height=150&src=pr&token=vVJxZexcTI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore)](https://app.codecov.io/gh/tianocore/edk2-pytool-extensions/pull/842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore) ```diff @@ Coverage Diff @@ ## master #842 +/- ## ========================================== - Coverage 78.75% 78.45% -0.30% ========================================== Files 49 40 -9 Lines 4909 4897 -12 ========================================== - Hits 3866 3842 -24 - Misses 1043 1055 +12 ``` | [Files](https://app.codecov.io/gh/tianocore/edk2-pytool-extensions/pull/842?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore) | Coverage Δ | | |---|---|---| | [edk2toolext/environment/repo\_resolver.py](https://app.codecov.io/gh/tianocore/edk2-pytool-extensions/pull/842?src=pr&el=tree&filepath=edk2toolext%2Fenvironment%2Frepo_resolver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore#diff-ZWRrMnRvb2xleHQvZW52aXJvbm1lbnQvcmVwb19yZXNvbHZlci5weQ==) | `91.53% <66.66%> (+1.15%)` | :arrow_up: | ... and [48 files with indirect coverage changes](https://app.codecov.io/gh/tianocore/edk2-pytool-extensions/pull/842/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tianocore)