search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

Revert 5714 devel/ovmf rdrand pedro #5772

Closed ardbiesheuvel closed 2 months ago

ardbiesheuvel commented 2 months ago

Reverts https://github.com/tianocore/edk2/pull/5714

Crypto unit tests are failing, ~possibly due to RDRAND issues on the CI infra servers~ due to a missing call to the RngLib constructor in the test cases.

@kraxel

(this replaces the github generated revert PR #5771 which did not pass the CI)

kraxel commented 2 months ago

Shouldn't we fix the test cases instead of reverting the whole thing?

Yes, the missing constructor call is one issue, easily fixed by sprinkling in a ProcessLibraryConstructorList() call.

Next problem is AsmCpuid() returning nothing. Simply setting the rdrand feature bit makes the test cases work. Which is strictly speaking is not correct, but the test cases used rdrand without an actual check before, so its at least not worse than it used to be.

https://github.com/tianocore/edk2/pull/5775

ardbiesheuvel commented 2 months ago

Strongly prefer the fix in #5775 - demoting to draft for now.