tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.58k stars 2.47k forks source link

MdeModulePkg/DisplayEngineDxe: Support "^" and "V" key on pop-up form #5788

Closed changab closed 3 months ago

changab commented 3 months ago

Description

BZ #4790 Support "^" and "V" key stokes on the pop-up form. Align the implementation with key support on the regular HII form.

changab commented 3 months ago

@dandanbi , Hi Dandan, do you have a chance to take a look at this PR?

dandanbi commented 3 months ago

Hi @changab, the change looks good to me. Assume you have done the unit test, it should work as expected, right?

changab commented 3 months ago

Hi @changab, the change looks good to me. Assume you have done the unit test, it should work as expected, right?

Right! This fix is verified on AMD platforms.

changab commented 3 months ago

@dandanbi, thank you! :)

changab commented 3 months ago

I rebase the branch to the latest code and will set the push label. Thanks!