tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.42k stars 2.4k forks source link

MdeModulePkg/DxeCapsuleLibFmp: Fix compilation error #5791

Closed nhivp closed 1 month ago

nhivp commented 1 month ago

Description

The commit "MdeModulePkg/DxeCapsuleLibFmp: Fix crash if no ESRT is found" leads to a compilation error in MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf. The issue occurs because the variable mDxeCapsuleLibReadyToBootEvent which is declared as extern does not exist, while it is defined in DxeCapsuleRuntime.c, a file not included in DxeCapsuleLib.inf. This patch is to fix this by moving the variable defintion to DxeCapsuleLib.c and declare it as extern in DxeCapsuleRuntime.c.

Reported-by: Gua Guo gua.guo@intel.com

How This Was Tested

Integration Instructions

mdkinney commented 1 month ago

Fixes build break introduced by https://github.com/tianocore/edk2/pull/5692