search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.58k stars 2.47k forks source link

StandaloneMM fixes for x86 #5814

Open PatrickRudolph opened 3 months ago

PatrickRudolph commented 3 months ago

Description

StandaloneMM fixes for x86.

How This Was Tested

Build using edk2-platform.

Integration Instructions

N/A

lgao4 commented 2 months ago

The change in BaseTools is good to me.

niruiyu commented 2 months ago

SEC and PEI images can execute in place because there are tight restrictions on the use of global variables and statically allocated buffers. This means that such PE images cannot have BSS sections, and so the compile time footprint of the image is identical to the runtime footprint.

I always have doubts about XIP. Thanks for clarifying the restriction of no BSS section:)

Is it guaranteed that this is also the case for standalone MM drivers? Where is this covered in the PI specification? Note that XIP generally means execute from flash, which is read-only. XIP from writable memory (or cache-as-RAM) is a different use case altogether, so before accepting these changes, I need to be convinced that the PI spec and the base tools cover this use case as well.

I do not think PI spec mandates anything on XIP. I am curious what mechanism has been there to check the non-existence of the BSS section for SEC and PEI.

github-actions[bot] commented 6 days ago

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

mergify[bot] commented 6 days ago

PR can not be merged due to conflict. Please rebase and resubmit