Add ACPI TPM2 table generator

[nvidia-dmach]

Description

• Add AcpiTpm2LibArm for generating ACPI TPM2 table using the information obtained from Tpm2InterfaceInfo CM object.

• Add helper function HexDump for printing hex dump of CM Object fields. Also merge multiple flavors of PrintCharX into one function PrintChars by using the field length.

• Add parser for Tpm2 CM object, which uses HexDump for dumping the 12 bytes of "StartMethodParameters" field.

• [ ] Breaking change?

• [ ] Impacts security?

• [ ] Includes tests?

How This Was Tested

• Verified that TPM2 table was created properly on platform that produces Tpm2InterfaceInfo CM object.
• Called ParseCmObjDesc() and ensured that all fields of the CM objects were printed correctly.

Integration Instructions

N/A

[pierregondois]

Also:

• I saw there is a revision 5 of the ACPI table, do you plan to add support for it (I didn't check how much modification this represent)
• Do you plan to add a parser for the table in acpiview ?
• There seems to be an SSDT table corresponding to this ACPI table, do you plan to generate it aswell ? Regards, Pierre

[nvidia-dmach]

Hi Pierre, Thanks for your review. Below are the answers to your questions:

• I saw there is a revision 5 of the ACPI table, do you plan to add support for it (I didn't check how much modification this represent) No, not at the moment. We can add rev 5 in the future patch.
• Do you plan to add a parser for the table in acpiview ? I suppose you mean the CM parser. If so, yes, it was added as the 3rd patch of this PR.
• There seems to be an SSDT table corresponding to this ACPI table, do you plan to generate it aswell ? The SSDT one is platform specific. So I think it's better to do in platform code instead.

BTW, I will be OOTO next week. Please expect some delay in my response.

Thanks, Dat

[pierregondois]

Hi Pierre, Thanks for your review. Below are the answers to your questions:

• I saw there is a revision 5 of the ACPI table, do you plan to add support for it (I didn't check how much modification this represent) No, not at the moment. We can add rev 5 in the future patch.
• Do you plan to add a parser for the table in acpiview ? I suppose you mean the CM parser. If so, yes, it was added as the 3rd patch of this PR.

There is a module in another package which allows to display ACPI tables, for instance: ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/

I was wondering if you were planning to add support to display this table aswell

• There seems to be an SSDT table corresponding to this ACPI table, do you plan to generate it aswell ? The SSDT one is platform specific. So I think it's better to do in platform code instead.

I think that all the ACPI tables are platform specific. The SSDT table seems complicated to generate, I was just wondering, no worries if we don't generate it.

BTW, I will be OOTO next week. Please expect some delay in my response.

Thanks, Dat

[nvidia-dmach]

Hi Pierre, Sami,

I have made fixes to my patch set. Please review again when you get a chance.

Thanks, Dat