tianocore / edk2

EDK II

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II

Other

4.38k stars 2.4k forks source link

SecurityPkg/Tcg2Config: Cast pointer type to VOID* to avoid potential build error. #5871

Closed td36 closed 4 days ago

td36 commented 4 days ago

Description

Cast pointer type to VOID to avoid potential build error. If the two PCD are FixAtBuild, PcdGetPtr will return a const type pointer. Since the second parameter of BuildGuidDataHob is VOID, build error may happen with following log: warning C4090: 'function': different 'const' qualifiers

How This Was Tested

Tested by tianocore edk2 CI

td36 commented 4 days ago

Hi @niruiyu @jyao1 , could you help review the PR?

leiflindholm commented 4 days ago

Why is the breaking-change label set?

td36 commented 4 days ago

Why is the breaking-change label set?

Hi Leif, the build error I mentioned happens on Intel internal platforms. So the tag is set for the PR to fix the issue

leiflindholm commented 16 hours ago

@td36 right, but my interpretation is that breaking-change is meant to indicate the PR, not what the PR is fixing.