search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.58k stars 2.47k forks source link

fix 4774 #5876

Closed wilson9chen closed 2 months ago

wilson9chen commented 3 months ago

  1. With the Command Prompt of [Developer Command Prompt for VS2015] ("C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\VsDevCmd.bat"), Launch:

    edksetup.bat

  2. Start the build by launch:

    Build -t VS2015

ERROR: Would get following build error message: 'c:\Program' is not recognized as an internal or external command, operable program or batch file. NMAKE : fatal error U1077: '"c:\Program Files\Windows Kits\8.1\bin\x86\rc.exe' : return code '0x1' Stop.

Fix the build error, Tested : TOOL_CHAIN_TAG = VS2015 (>Build -t VS2015) TOOL_CHAIN_TAG = VS2015x86 (>Build -t VS2015x86)

Description

<_Include a description of the change and why this change was made._> <_For each item, place an "x" in between `[` and `]` if true. Example: `[x]` (you can also check items in GitHub UI)_> <_Create the PR as a Draft PR if it is only created to run CI checks._> <_Delete lines in \<\> tags before creating the PR._> - [ ] Breaking change? - **Breaking change** - Will this cause a break in build or boot behavior? - Examples: Add a new library class or move a module to a different repo. - [ ] Impacts security? - **Security** - Does the change have a direct security impact? - Examples: Crypto algorithm change or buffer overflow fix. - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests or integration tests. ## How This Was Tested <_Describe the test(s) that were run to verify the changes._> ## Integration Instructions <_Describe how these changes should be integrated. Use N/A if nothing is required._>
leiflindholm commented 3 months ago

"fix 4774" is not an appropriate PR title, nor commit message title. Please update as per the same rules that have always applied for cover letters and commit messages.

os-d commented 3 months ago

@bcran, with VS2022 support being added to edk2 (https://github.com/tianocore/edk2/pull/5799), can we drop support for VS2015, which is now almost 10 years old and unmaintained? I would not expect that it continues to be able to build the codebase and may require spurious updates, either to config, like this, or actual code that no longer meets its baroque requirements.

@wilson9chen, I would highly recommend moving forward to VS2022.

lgao4 commented 2 months ago

@bcran, with VS2022 support being added to edk2 (#5799), can we drop support for VS2015, which is now almost 10 years old and unmaintained? I would not expect that it continues to be able to build the codebase and may require spurious updates, either to config, like this, or actual code that no longer meets its baroque requirements.

@wilson9chen, I would highly recommend moving forward to VS2022.

This proposal can be raised in edk2 dev mail list. devel@edk2.groups.io

lgao4 commented 2 months ago

"fix 4774" is not an appropriate PR title, nor commit message title. Please update as per the same rules that have always applied for cover letters and commit messages.

please follow https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format to update commit message.