tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

Mpam ACPI and parser changes #5888

Closed rohit-arm closed 1 month ago

rohit-arm commented 1 month ago

Description

This series adds the following

An MPAM ACPI table formulated using the newly added MPAM ACPI definitions= were validated on the linux kernel tree at [1]. The same table was parsed via acpiview using the newly added parser. Certain aspects of the MPAM ACPI specification are still not implemented by the kernel tree. These aspects were verified only using acpiview.

Changes since V1:

Changes since V2:

Changes since v3:

Changes since v4:

Changes from v5:

This PR can cause a break in the build as it touches the code. However all the build CIs have gone through and therefore I don't anticipate build failures post merge. For boot, the scope of this PR is mostly restricted for UEFI shell. It adds a new parser for MPAM ACPI table which is relevant only when UEFI shell is up.

How This Was Tested

This PR was tested using different versions of non-mainline kernel supporting MPAM. The description of the changes detail this.

Integration Instructions

N/A

rohit-arm commented 1 month ago

@samimujawar - Gentle reminder on the series.

mergify[bot] commented 1 month ago

PR can not be merged due to conflict. Please rebase and resubmit

samimujawar commented 1 month ago

@ZhichaoGao This patch series looks good to me. Is it possible to apply the push label, please?

rohit-arm commented 1 month ago

Hi, there was a CI failure yesterday as this patch-set introduces prototype changes for 2 widely used Parser APIs (https://github.com/tianocore/edk2/pull/5888/commits/d6f78b5641d43470db28970ec066608edf2ec1d8 and https://github.com/tianocore/edk2/pull/5888/commits/b96f9191cfd618021764a6a394607d2eecf2132a). Anytime something gets merged upstream touching these prototypes, I would need to manual re-adapt the patch-set so that everything upstream utilizes the new prototype.

The following PRs were merged after this patch-set was posted for review 3 weeks back. https://github.com/tianocore/edk2/pull/5747 https://github.com/tianocore/edk2/pull/5749

I have updated the patch-set now to align everything on upstream with the new prototype.

Tagging @ZhichaoGao @lgao4 as well - as it introduces prototype changes, gentle request if we can get this merged before upstream moves further.

Thanks!