Related to the discussion in #5893, replacing #5867 based on conversation with @mdkinney and @ajfish.
The conversation on what to do with regards to the style rules will be a longer one. This change lets us merge #5840 while that conversation is ongoing.
Patch 1/2 still fixes a consistent misspelling of ASCII in ECC.
Patch 2/2 now completely deletes the GeneralCheckNoAscii() test from ECC. However, there are some other tests that still verify (via regex) various identifiers against naming standards from the coding style, enforcing a subset of ASCII there.
My intent is to follow this PR with one adding ASCII-checks for remaining identifier types, as an RFC.
Related to the discussion in #5893, replacing #5867 based on conversation with @mdkinney and @ajfish.
The conversation on what to do with regards to the style rules will be a longer one. This change lets us merge #5840 while that conversation is ongoing.
Patch 1/2 still fixes a consistent misspelling of ASCII in ECC.
Patch 2/2 now completely deletes the GeneralCheckNoAscii() test from ECC. However, there are some other tests that still verify (via regex) various identifiers against naming standards from the coding style, enforcing a subset of ASCII there.
My intent is to follow this PR with one adding ASCII-checks for remaining identifier types, as an RFC.