tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

BaseTools/HostBasedUnitTestRunner: Promote Unittest error to CI fail. #5905

Closed apop5 closed 1 month ago

apop5 commented 1 month ago

Description

Some unit tests would fail to execute or execute and not produce any output logs. In these cases, the only output would be in the CI Log as UnitTest Execution Error.

A UnitTest Execution Error should be considered the same as a unit tests test failing.

How This Was Tested

When running a unit test on a repo where the unit test was not implemented correctly, CI would still pass. After making this change, the unit test execution error was reported as CI failure.

Integration Instructions

Impact to unit tests that are silently failing. On a case by case basis, those unit tests will need to be modified to be able to execute.

apop5 commented 1 month ago

@Javagedes