tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

BaseTools: fix spec keyword parsing #5906

Closed Ashwin-Veeraiah closed 1 month ago

Ashwin-Veeraiah commented 1 month ago

Fixes SPEC keyword parsing to match EDK2 specification

Description

When SPEC keyword is used in the INF file, it does not create the equivalent #define in the autogen.h file of the module. Additionally it creates a line in autogenerated makefile. This generated line will cause builds to break of we follow the specification as defined in the example here, [https://github.com/tianocore-docs/edk2-InfSpecification/blob/master/3_edk_ii_inf_file_format/34_%5Bdefines%5D_section.md] Ex : SPEC USB_SPECIFICATION_VERSION = 2.0 The changes fixes the autogen code to function as mentioned by the documentation.

How This Was Tested

Tested locally with builds.

Integration Instructions

N/A

mergify[bot] commented 1 month ago

PR can not be merged due to conflict. Please rebase and resubmit