tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

MdePkg: Define SMBIOS Protocol header according IndustryStandard #5912

Closed MarsDoge closed 1 month ago

MarsDoge commented 1 month ago

Description

MdePkg: Define SMBIOS Protocol header according IndustryStandard As the SMBIOS table types belong to the SMBIOS standard, they were moved from the SMBIOS IndustryStandard into the SMBIOS Protocol header with the EFI_-prefix.

Filling in definitions facilitates consistent use of header files: EFI_SMBIOS_TYPE_TPM_DEVICE EFI_SMBIOS_TYPE_PROCESSOR_ADDITIONAL_INFORMATION EFI_SMBIOS_TYPE_FIRMWARE_INVENTORY_INFORMATION EFI_SMBIOS_TYPE_STRING_PROPERTY_INFORMATION

Cc: Michael D Kinney michael.d.kinney@intel.com Cc: Liming Gao gaoliming@byosoft.com.cn Cc: Zhiguang Liu zhiguang.liu@intel.com Cc: Chao Li lichao@loongson.cn Signed-off-by: Dongyan Qian qiandongyan@loongson.cn

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

leiflindholm commented 1 month ago

Please change the PR title to something that contains information.

kilaterlee commented 1 month ago

@lgao4 @mdkinney , Hi Liming and Mike, Do you have any comments on patch 2?

mdkinney commented 1 month ago

Can this be split into 2 PRs? I do not think the think the SMBIOS .h files changes should be in same PR as LOONGARCH64 csr.

MarsDoge commented 1 month ago

Can this be split into 2 PRs? I do not think the think the SMBIOS .h files changes should be in same PR as LOONGARCH64 csr.

Thanks for your review, I have removed the LOONGARCH64 csr from this PR.