tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.52k stars 2.44k forks source link

Add Memory Attribute Protocol Logging #5925

Closed os-d closed 1 month ago

os-d commented 1 month ago

Description

The memory attribute protocol is primarily used by bootloaders and there are many released bootloaders who use the protocol incorrectly. It is challenging to debug these situations because the bootloaders are generally black boxes and we silently fail on the FW side. This patch series adds logging for ARM32 and AARCH64 to log during failures of the memory attribute protocol (and in ArmMmuLib) for commonly seen bootloader failures using the memory attribute protocol.

How This Was Tested

Tested on virtual platforms with a failing bootloader and saw the messages printed.

Integration Instructions

N/A.

os-d commented 1 month ago

@ardbiesheuvel @leiflindholm @samimujawar can you please review?

ardbiesheuvel commented 1 month ago

@os-d #5933

For some reason, GitHub does not allow me to cc you on that PR - any idea why? (your name does not appear in the 'reviewers' pulldown list, or the one that opens when you type @ in a comment box)

os-d commented 1 month ago

@ardbiesheuvel, I would imagine that I cannot be added to the reviewers pulldown list because I am not in the edk2 maintainers/reviewers group (@makubacki / @mdkinney ?), but I'm not sure why the @ in the comment box didn't work, it clearly worked on this PR

makubacki commented 1 month ago

@ardbiesheuvel, I would imagine that I cannot be added to the reviewers pulldown list because I am not in the edk2 maintainers/reviewers group (@makubacki / @mdkinney ?)

Correct. Write permission is needed to be added as a reviewer. Also, to my understanding, the PR author cannot be added as a reviewer.