search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.64k stars 2.51k forks source link

ShellPkg: Add support to parse SPMI table in acpiview #5980

Open shkrc opened 3 months ago

shkrc commented 3 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar AbdulLateef.Attar@amd.com Cc: Abner Chang abner.chang@amd.com Cc: Paul Grimes paul.grimes@amd.com Cc: Zhichao Gao zhichao.gao@intel.com Signed-off-by: Shankar C shankar.c@amd.com

Description

<_Include a description of the change and why this change was made._> <_For each item, place an "x" in between `[` and `]` if true. Example: `[x]` (you can also check items in GitHub UI)_> <_Create the PR as a Draft PR if it is only created to run CI checks._> <_Delete lines in \<\> tags before creating the PR._> - [ ] Breaking change? - **Breaking change** - Does this PR cause a break in build or boot behavior? - Examples: Does it add a new library class or move a module to a different repo. - [ ] Impacts security? - **Security** - Does this PR have a direct security impact? - Examples: Crypto algorithm change or buffer overflow fix. - [ ] Includes tests? - **Tests** - Does this PR include any explicit test code? - Examples: Unit tests or integration tests. ## How This Was Tested <_Describe the test(s) that were run to verify the changes._> ## Integration Instructions <_Describe how these changes should be integrated. Use N/A if nothing is required._>
abdattar commented 3 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar AbdulLateef.Attar@amd.com Cc: Abner Chang abner.chang@amd.com Cc: Paul Grimes paul.grimes@amd.com

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao zhichao.gao@intel.com

shkrc commented 3 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818 Added support for acpiview shell utility to parse and print SPMI table Cc: Abdul Lateef Attar AbdulLateef.Attar@amd.com Cc: Abner Chang abner.chang@amd.com Cc: Paul Grimes paul.grimes@amd.com

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao zhichao.gao@intel.com

hi, i added in the commit but it did not reflect in the description. ill just edit the description

lgao4 commented 3 months ago

Could you attach the dump result for SPMI table?

abdattar commented 3 months ago

@shkrc can you paste the acpiview -S SPMI output ?

shkrc commented 3 months ago

spmi.log I have attached the log here

shkrc commented 2 months ago

Hi @lgao4 can you help review this patch?

abdattar commented 2 months ago

Hi @ZhichaoGao could you please merge the changes.

abdattar commented 1 month ago

could you please push the code changes?

mergify[bot] commented 1 month ago

PR can not be merged due to conflict. Please rebase and resubmit

shkrc commented 1 month ago

Hi @lgao4 @ZhichaoGao can you help review this patch?