apop5 commented 3 months ago

Description

SnpDxe registers for an ExitBootServices callback and runs the PXE_OPCODE_SHUTDOWN and PXE_OPCODE_STOP commands for any network controllers that the driver is attached to.

Register the SnpDxe callback for gEfiEventBeforeExitBootServicesGuid instead of gEfiEventExitBootServicesGuid to ensure the correct ordering:

ExitBootServices event
Network card shutdown sequence is completed

Also, close the event to prevent rerunning the shutdown if multiple ExitBootServices events need to be called by the OS.

[ ] Breaking change?
- Breaking change - Does this PR cause a break in build or boot behavior?
- Examples: Does it add a new library class or move a module to a different repo.
[ ] Impacts security?
- Security - Does this PR have a direct security impact?
- Examples: Crypto algorithm change or buffer overflow fix.
[ ] Includes tests?
- Tests - Does this PR include any explicit test code?
- Examples: Unit tests or integration tests.

How This Was Tested

Verified PXE boot was able to complete.

Integration Instructions

N/A

github-actions[bot] commented 3 months ago

⚠ WARNING: Cannot add reviewers: A user specified as a reviewer for this PR is not a collaborator of the edk2 repository. Please add them as a collaborator to the repository and re-request the review.

Users requested: ajfish, leiflindholm, mdkinney, SaloniKasbekar, Zclarkwilliams

makubacki commented 3 months ago

⚠ WARNING: Cannot add reviewers: A user specified as a reviewer for this PR is not a collaborator of the edk2 repository. Please add them as a collaborator to the repository and re-request the review.

Users requested: ajfish, leiflindholm, mdkinney, SaloniKasbekar, Zclarkwilliams

@mdkinney