search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.67k stars 2.53k forks source link

Bad variable interpolation in UefiPayloadPkg.dsc #6135

Open matdibu opened 2 months ago

matdibu commented 2 months ago

https://github.com/tianocore/edk2/blob/bb248a95091ab542440053d9c289a97e80eb6630/UefiPayloadPkg/UefiPayloadPkg.dsc#L25

does that actually evaluate as intended? on my local machine I get this:

$ ls Build/
'UefiPayloadPkg$(BUILD_ARCH)'

which in turn breaks the build

ProfessorLongBeard commented 2 months ago

https://github.com/tianocore/edk2/blob/bb248a95091ab542440053d9c289a97e80eb6630/UefiPayloadPkg/UefiPayloadPkg.dsc#L25

does that actually evaluate as intended? on my local machine I get this:

$ ls Build/
'UefiPayloadPkg$(BUILD_ARCH)'

which in turn breaks the build

Seems like your local machine is garbage.

matdibu commented 2 months ago

:))) I didn't expect that

but seriously now, could it be because of the shell using during the build?

it was from within a nix derivation, so the shell definitely isn't the same as a user-interactive bash session started on ubuntu

that being said, the build worked after I replaced that with Build/UefiPayloadPkgX64, and I successfully flashed and booted on real hardware