search

tianocore / edk2

EDK II
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
Other
4.54k stars 2.45k forks source link

RamDiskDxe: removal action doesn't do anything when 9 disks exist #81

Closed bcran closed 8 years ago

bcran commented 8 years ago

If a user creates 9 raw RAM Disks using the default size of 0x1000, then at some point some of them become selected ("[X]") in the list automatically.

Furthermore, the "Remove selected RAM disk(s)." option appears to have no effect anymore - none of the disks are deleted.

Pressing ESC to leave the screen causes a "Changes have not been saved. Save Changes and exit?" dialog to appear. Pressing 'Y' has no effect.

bcran commented 8 years ago

Label issue as OVMF.

lersek commented 8 years ago

Hm, I don't think it is right to label this as OVMF. OvmfPkg does not provide any code related specifically to RAM Disks. I think it would be more appropirate to attribute this to RamDiskDxe, since the exact string that you quote ("Remove selected RAM disk(s)") can be found in MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskHiiStrings.uni.

hwu25 commented 8 years ago

It is a bug for the RamDiskDxe driver in the MdeModulePkg. I will send out a patch to fix this issue later.

lersek commented 8 years ago

Patch on list: http://thread.gmane.org/gmane.comp.bios.edk2.devel/10968

hwu25 commented 8 years ago

The issue is fixed by commit 09abc636756b5d1f29224402181f7fd34f736c5f. @lersek Could you help to close this issue?

lersek commented 8 years ago

@hwu25: closing.

But, as a tianocore group member, I think you should also be able to close edk2 project issues. @jljusten, any thoughts? Thanks.