search

tianon / docker-postgres-upgrade

a PoC for using "pg_upgrade" inside Docker -- learn from it, adapt it for your needs; don't expect it to work as-is!
https://hub.docker.com/r/tianon/postgres-upgrade/
MIT License
1.09k stars 116 forks source link

Add support timescaledb #44

Closed mnival closed 2 years ago

mnival commented 2 years ago

Hello,

Proposal of a solution for the support of timescaledb Copy configuration from previous version to new version after initdb

tianon commented 2 years ago

Sorry, I'm really confused -- why would it make sense to add explicit timescaledb support to this repository?

My intention for creating this repository was an example of one way to solve the "postgres upgrade in containers" problem, not necessary "the only way to solve" :see_no_evil:

mnival commented 2 years ago

Hello,

I understand and I just saw your comment in https://github.com/tianon/docker-postgres-upgrade/issues/33.

Maybe only this part : cp -p ${PGDATANEW}/*.conf ${PGDATANEW}/new_conf/ [ -e ${PGDATAOLD}/pg_hba.conf.conf ] && cp -p ${PGDATAOLD}/pg_hba.conf ${PGDATANEW}/ [ -e ${PGDATAOLD}/postgresql.conf ] && cp -p ${PGDATAOLD}/postgresql.conf ${PGDATANEW}/

I don't know if it's a good idea to restore the previous configuration in the new data.

I close this pull request.