Add QEMU_NO_VNC to start-qemu for disabling VNC

tianon / docker-qemu

Dockerization of supported QEMU releases

https://qemu.org

133 stars 34 forks source link

Add QEMU_NO_VNC to start-qemu for disabling VNC #8

Closed MaxPeal closed 4 years ago

MaxPeal commented 4 years ago

a run of update.sh is still needed

tianon commented 4 years ago

I'm +1 on the start-qemu change, but I'm not a fan of the README.md changes -- the usage of /home/jsmith was intentional to make sure it wasn't something someone could copy/paste directly since it's intended to be an example folks adapt to their own use case. :sweat_smile:

Can you split those out? (If you'd rather, I'm happy to update your PR for you. :+1:)

MaxPeal commented 4 years ago

shure you can update my PR and remove the changes form the README.md

tianon commented 4 years ago

Thank you! :+1: