[Fix] Update niconico request URL in `onRequest` trigger

tiansh / ass-danmaku

A firefox extension for downloading danmaku (video comments); Online converter: https://tiansh.github.io/ass-danmaku-online/

https://addons.mozilla.org/en-US/firefox/addon/ass-danmaku/

Mozilla Public License 2.0

60 stars 12 forks source link

[Fix] Update niconico request URL in `onRequest` trigger #15

Closed maristie closed 2 years ago

maristie commented 3 years ago

niconico seems to have changed their request URL for comment file.

tiansh commented 3 years ago

Should I replace the old one (as what you did) or add another one while keeping the old one as is? As the API is marked as "legacy", should I add support to any other API's?

maristie commented 3 years ago

It might be more robust to add multiple URLs / endpoints instead of replacing. I'm not sure about whether Niconico would change it again. All of the changes are based on inspecting their HTTP POST requests, after I found old extension was unusable.