search

tiansh / ass-danmaku

A firefox extension for downloading danmaku (video comments); Online converter: https://tiansh.github.io/ass-danmaku-online/
https://addons.mozilla.org/en-US/firefox/addon/ass-danmaku/
Mozilla Public License 2.0
64 stars 12 forks source link

Extension stopped working in Firefox 129 #24

Open HayashiKaori opened 2 months ago

HayashiKaori commented 2 months ago

I upgraded Firefox this morning to v129, but now this awesomely useful extension no longer works. Could this please be fixed? This extension is one of my favorite ones, so i really hope it will be fixed or if someone else will fork it and make it work again 😋

maristie commented 2 months ago

I suggest you list websites on which the extension fails such that others can reproduce it.

UBTL commented 2 months ago

Greetings, the site that stopped working is NicoNico now they are back online and with another different backend apparently

HayashiKaori commented 2 months ago

是B站弹幕下载没有显示下载按钮，以前需要手动下拉弹幕列表，才会出现。 运行环境： win11 Firefox129.0.2 (64 位）

maristie commented 2 months ago

Greetings, the site that stopped working is NicoNico now they are back online and with another different backend apparently

@UBTL Please refer to https://github.com/tiansh/ass-danmaku/pull/22 but update the URL to '*://public.nvcomment.nicovideo.jp/v1/threads'

maristie commented 2 months ago

是B站弹幕下载没有显示下载按钮，以前需要手动下拉弹幕列表，才会出现。 运行环境： win11 Firefox129.0.2 (64 位）

@HayashiKaori Please try this PR https://github.com/tiansh/ass-danmaku/pull/27

UBTL commented 2 months ago

Greetings, the site that stopped working is NicoNico now they are back online and with another different backend apparently

@UBTL Please refer to #22 but update the URL to '*://public.nvcomment.nicovideo.jp/v1/threads'

alright thank very much for trying to fix it, however try to change the addon or add the addon manually is such an absolute pain so I would rather wait if you could be kind to update the addon on the Mozilla Addon page if possible

maristie commented 2 months ago

Greetings, the site that stopped working is NicoNico now they are back online and with another different backend apparently

@UBTL Please refer to #22 but update the URL to '*://public.nvcomment.nicovideo.jp/v1/threads'

alright thank very much for trying to fix it, however try to change the addon or add the addon manually is such an absolute pain so I would rather wait if you could be kind to update the addon on the Mozilla Addon page if possible

Agree, it's a pain for me too. However, only the repo owner can merge & publish the updated add-on in Mozilla Add-on page. So unfortunately I can't do anything until @tiansh is back.