search

tianyue58 / pe

0 stars 0 forks source link

Inaccurate parameter provided #15

Open tianyue58 opened 3 years ago

tianyue58 commented 3 years ago

Screenshot 2021-11-12 at 5.36.29 PM.png

The input parameter in parseCommand should be " 3 n/Report 4", not "3 n/Report 4" based on the code on github.

nus-pe-bot commented 3 years ago

Team's Response

I do agree that this is a bug and it may cause some confusion to the reader. However, I believe that the inaccurate parameter provided for the parseCommand method is unlikely to affect normal operations of the product, and it appears only in very rare situations and causes a minor inconvenience for the reader. In addition, this could fall under the category of typos and it is mentioned in the screenshot below that it is considered to be of very low severity.

Screenshot 2021-11-14 at 11.36.49 PM.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I disagree with the downgrading of severity for the following reasons. First of all, I do not think this bug can be regarded as a typo. Typo is supposed to be a minor mistake made accidentally when typing. However, This mistake happens throughout ALL the UML diagrams in the DG and it is inherited from AB3 DG. Hence, it is more likely that this is an omission of details by your team. Additionally, as this error occurs throughout all the UML diagrams throughout your DG, it could cause confusion to many readers when they first trace the code to understand the system behaviour and find diverging results on their side. Hope this explanation helps. Thank you!