nus-pe-bot
commented
2 years ago Team's Response
Accepted that the duplication detection mechanism should be more sophisticated.
However, I believe that the severity is not enough to be medium. First of all, for a proper user that does not try to crash the system on purpose, this situation mostly happens when he/she forgot the student is already in TutorMaster.
- If the tutor has a small number of students, then it is likely that he/she will check if the student is on the list before adding it. Even if missing that, it is easy for him/her to detect such duplication.
- If the tutor has a lot of students (e.g., more than 20 students), then mostly he/she is teaching a large class instead of having 10+ one-to-one teaching. In this case, the student data is more likely to be added into the
.jsonfile together instead of manually adding each student's detail. Moreover, the data is added as a group and should only be changed if new students join/leave the class. Therefore, it is unlikely for the tutor to add a student twice with slightly different detail.
We admit that the problem stated in the bug report can still happen. We just want to stress that such cases are not often, and the severity should be low instead.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Description: Duplicate detection is only limited to the exact string/value matches. For example, John Doe and john doe are likely to be the same person. Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons.
Steps to reproduce: "student -a n/John Doe p/90001111 e/david@gmail.com a/Singapore" "student -a n/john doe p/90001111 e/david@gmail.com a/Singapore" "student -a n/john doe p/90001111 e/david@gmail.com a/Singapore"
Expected: Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.
Actual: No warning is given, they are directly recognised as different persons.