search

tibiamaps / tibia-map-data

:beginner: Fully explored Tibia maps in a human-readable format.
https://tibiamaps.io/downloads
MIT License
82 stars 20 forks source link

Some Carlin Surroundings and Field of Glory PoIs #221

Closed muriloricci closed 1 year ago

muriloricci commented 2 years ago

minimapmarkers.zip

mathiasbynens commented 1 year ago

This looks like it needs to be rebased, or otherwise filtered to only consider the newly added markers (and not remove any). @rmobis, IIRC you were working on something to make this easier, right? What's the status on that?

rmobis commented 1 year ago

@mathiasbynens I've opened tibia-maps-script#26 which could help alleviate this issue, but since it got no response I wasn't sure whether to progress further. If that's something you feel would be a good addition, please let me know.

Edit: I feel like with this, we could even set a bot that automatically opens PRs based on issues with minimapmarkers.zip for POIs.

mathiasbynens commented 1 year ago

Apologies for dropping the ball there. I just responded to that issue. Would be amazing to have --union implemented as a first step! And yes, the GitHub bot idea is neat too :)

muriloricci commented 1 year ago

Can this be closed?

rmobis commented 1 year ago

@muriloricci Sadly, no. We're waiting on the development of a new feature in the tibia-maps-scripts repo to allow us to easily import those, as they were made with outdated markers. I've been kinda stalling to finish that though, but I'll try and do it this weekend.

mathiasbynens commented 1 year ago

@rmobis Any updates? :)

rmobis commented 1 year ago

@mathiasbynens thanks for friendly poke, it push me to finally get it done. I've opened PR https://github.com/tibiamaps/tibia-maps-script/pull/28

mathiasbynens commented 1 year ago

🥳